rustc_target: Add some more target spec sanity checking#100537
Merged
bors merged 4 commits intorust-lang:masterfrom Sep 1, 2022
Merged
rustc_target: Add some more target spec sanity checking#100537bors merged 4 commits intorust-lang:masterfrom
bors merged 4 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
T-compiler
Contributor
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
Contributor
|
rust-highfive
added
the
S-waiting-on-review
petrochenkov
commented
Aug 14, 2022
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
@rustbot ready |
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
@bors r+ rollup=never (for bisectability) |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Sep 1, 2022
Merged
Collaborator
|
Finished benchmarking commit (aa857eb): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
nicholasbishop
added a commit
to nicholasbishop/rust
that referenced
this pull request
Sep 9, 2022
In rust-lang#100537, the relocation model for UEFI targets was changed from PIC (the default value) to static. There was some dicussion of this change here: rust-lang#100537 (comment) It turns out that this can cause compilation to fail as described in rust-lang#101377, so switch back to PIC. Fixes rust-lang#101377
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 10, 2022
…static-reloc, r=petrochenkov Use RelocModel::Pic for UEFI targets In rust-lang#100537, the relocation model for UEFI targets was changed from PIC (the default value) to static. There was some dicussion of this change here: rust-lang#100537 (comment) It turns out that this can cause compilation to fail as described in rust-lang#101377, so switch back to PIC. Fixes rust-lang#101377
RalfJung
reviewed
Nov 24, 2024
Comment on lines
+151
to
+153
| if self.relocation_model == RelocModel::Pic { | ||
| assert!(self.dynamic_linking || self.position_independent_executables); | ||
| } |
Member
There was a problem hiding this comment.
This requirement is a bit odd since our default values for target options violate it -- the default relocation model is PIC, but the default for dynamic_linking and position_independent_executables is false. This is causing some trouble in #133409.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.